fix bug scan ip

core/scanner.py

@@ -1,23 +1,31 @@
 import subprocess
 import sys
 import ipaddress
+import threading
 from concurrent.futures import ThreadPoolExecutor, as_completed
 
 # Windows: prevent subprocess from opening visible console windows
 _NO_WINDOW = subprocess.CREATE_NO_WINDOW if sys.platform == "win32" else 0
 
+# Concurrent ping workers per platform
+_MAX_WORKERS_WIN = 50
+_MAX_WORKERS_OTHER = 64
+
 
 def _ping_one(ip, is_win):
     """Ping a single IP. Returns True if host responds."""
     try:
         if is_win:
+            # Capture stdout to check for TTL= — more reliable than returncode
+            # on Windows (returncode can be 0 even for "Destination unreachable")
             r = subprocess.run(
                 ["ping", "-n", "1", "-w", "500", str(ip)],
-                stdout=subprocess.DEVNULL,
+                stdout=subprocess.PIPE,
                 stderr=subprocess.DEVNULL,
                 timeout=3,
                 creationflags=_NO_WINDOW
             )
+            return r.returncode == 0 and b"TTL=" in r.stdout
         elif sys.platform == "darwin":
             r = subprocess.run(
                 ["ping", "-c", "1", "-W", "300", str(ip)],
@@ -49,17 +57,22 @@ def _ping_sweep(network, progress_cb=None):
     is_win = sys.platform == "win32"
     hosts = list(net.hosts())
     total = len(hosts)
+    workers = min(_MAX_WORKERS_WIN if is_win else _MAX_WORKERS_OTHER, len(hosts))
+
     done_count = [0]
+    lock = threading.Lock()
     alive = []
 
     def _ping_and_track(ip):
         ok = _ping_one(ip, is_win)
-        done_count[0] += 1
+        with lock:
+            done_count[0] += 1
+            current = done_count[0]
         if progress_cb:
-            progress_cb(done_count[0], total)
+            progress_cb(current, total)
         return (str(ip), ok)
 
-    with ThreadPoolExecutor(max_workers=min(64, len(hosts))) as executor:
+    with ThreadPoolExecutor(max_workers=workers) as executor:
         futures = [executor.submit(_ping_and_track, ip) for ip in hosts]
         for f in as_completed(futures):
             ip_str, ok = f.result()